Re: [PATCH][next] mt76: fix less than zero check on a u8 variable

From: Felix Fietkau
Date: Sat May 11 2019 - 09:33:06 EST

On 2019-05-05 23:31, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> The signed return from the call to get_omac_idx is being assigned to the
> u8 variable mac_idx and then checked for a negative error condition
> which is always going to be false. Fix this by assigning the return to
> the int variable ret and checking this instead.
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 04b8e65922f6 ("mt76: add mac80211 driver for MT7615 PCIe-based chipsets")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
Already fixed by a similar patch by Dan Carpenter.

- Felix