Re: [PATCH 2/2] afs: Fix afs_xattr_get_yfs() to not try freeing an error value
From: David Howells
Date: Sun May 12 2019 - 16:08:14 EST
walter harms <wharms@xxxxxx> wrote:
> Sorry, you misunderstood me, my fault, i did not see that size is unsigned.
> NTL i do not think size=0 is useful.
Allow me to quote from the getxattr manpage:
If size is specified as zero, these calls return the current size of
the named extended attribute (and leave value unchanged). This can be
used to determine the size of the buffer that should be supplied in a
subsequent call. [...]
> while you are there:
> flags |= YFS_ACL_WANT_ACL is always flags = YFS_ACL_WANT_ACL;
> since flags is 0 at this point.
> IMHO that sould be moved to the strcmp() section.
Why? It makes the strcmp() section more complicated and means I now either
have to cache flags in a variable or do the allocation of yacl first.