Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG

[Taniya Das]

Hello Stephen,

On 5/10/2019 11:24 PM, Stephen Boyd wrote:
> Quoting Taniya Das (2019-05-09 19:58:39)
> > Hello Stephen,
> >
> > Thanks for the review.
> >
> > On 5/9/2019 10:57 PM, Stephen Boyd wrote:
> > > Quoting Taniya Das (2019-05-08 11:24:55)
> > > > Update the init data name for each of the dynamic frequency switch
> > > > controlled clock associated with the RCG clock name, so that it can be
> > > > generated as per the hardware plan. Thus update the macro accordingly.
> > > >
> > > > Signed-off-by: Taniya Das <tdas@xxxxxxxxxxxxxx>
> > >
> > > This patch doesn't make any sense to me.
> > >
> > > > ---
> > > >    drivers/clk/qcom/clk-rcg.h    |  2 +-
> > > >    drivers/clk/qcom/gcc-sdm845.c | 96 +++++++++++++++++++++----------------------
> > > >    2 files changed, 49 insertions(+), 49 deletions(-)
> > > >
> > > > diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h
> > > > index 5562f38..e40e8f8 100644
> > > > --- a/drivers/clk/qcom/clk-rcg.h
> > > > +++ b/drivers/clk/qcom/clk-rcg.h
> > > > @@ -171,7 +171,7 @@ struct clk_rcg_dfs_data {
> > > >    };
> > > >
> > > >    #define DEFINE_RCG_DFS(r) \
> > > > -       { .rcg = &r##_src, .init = &r##_init }
> > > > +       { .rcg = &r, .init = &r##_init }
> > >
> > > Why do we need to rename the init data?
> >
> > We want to manage the init data as the clock source name, so that we
> > could manage to auto generate our code. So that we do not have to
> > re-name the clock init data manually if the DFS source names gets
> > updated at any point of time.
>
> Why is the clk name changing to not have a _src after the "root" of the
> clk name? As long as I can remember, RCGs have a "_src" postfix.

Yes, the RCGs would have _src, so we do want the init data also to be
generated with _src postfix. So that we do not have to manually clean up 
the generated code.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--