Re: [PATCH V6 06/15] dt-bindings: PCI: designware: Add binding for CDM register check
From: Rob Herring
Date: Mon May 13 2019 - 11:12:15 EST
On Mon, May 13, 2019 at 10:36:17AM +0530, Vidya Sagar wrote:
> Add support to enable CDM (Configuration Dependent Module) registers check
> for any data corruption. CDM registers include standard PCIe configuration
> space registers, Port Logic registers and iATU and DMA registers.
> Refer Section S.4 of Synopsys DesignWare Cores PCI Express Controller Databook
> Version 4.90a
> Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
> Changes since [v5]:
> * None
> Changes since [v4]:
> * None
> Changes since [v3]:
> * None
> Changes since [v2]:
> * Changed flag name from 'cdm-check' to 'enable-cdm-check'
> * Added info about Port Logic and DMA registers being part of CDM
> Changes since [v1]:
> * This is a new patch in v2 series
> Documentation/devicetree/bindings/pci/designware-pcie.txt | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt
> index 5561a1c060d0..85b872c42a9f 100644
> --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt
> @@ -34,6 +34,11 @@ Optional properties:
> - clock-names: Must include the following entries:
> - "pcie"
> - "pcie_bus"
> +- enable-cdm-check: This is a boolean property and if present enables
> + automatic checking of CDM (Configuration Dependent Module) registers
> + for data corruption. CDM registers include standard PCIe configuration
> + space registers, Port Logic registers, DMA and iATU (internal Address
> + Translation Unit) registers.
> RC mode:
> - num-viewport: number of view ports configured in hardware. If a platform
> does not specify it, the driver assumes 2.