Re: [PATCH 4/4] Revert "platform/chrome: cros_ec_spi: Transfer messages at high priority"

From: Doug Anderson
Date: Mon May 13 2019 - 12:05:17 EST


On Mon, May 13, 2019 at 9:02 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Mon, May 13, 2019 at 08:57:12AM -0700, Doug Anderson wrote:
> > On Sun, May 12, 2019 at 10:05 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
> > > It isn't clear to me that it's a bad thing to have this even with the
> > > SPI thread at realime priority.
> > The code that's there right now isn't enough. As per the description
> > in the original patch, it didn't solve all problems but just made
> > things an order of magnitude better. So if I don't do this revert I
> I'm not saying the other changes aren't helping, I'm saying that it's
> not clear that this revert is improving things.

If I add a call to force the pumping to happen on the SPI thread then
the commit I'm reverting here is useless though, isn't it?