Re: [PATCH v9 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit

From: Joe Perches
Date: Mon May 13 2019 - 12:07:08 EST

On Mon, 2019-05-13 at 08:35 -0700, Angus Ainslie wrote:
> Hi Joe,


> On 2019-05-13 08:11, Joe Perches wrote:
> > On Mon, 2019-05-13 at 07:55 -0700, Angus Ainslie (Purism) wrote:
> > > This is for the development kit board for the Librem 5. The current
> > > level
> > > of support yields a working console and is able to boot userspace from
> > > the network or eMMC.
> > []
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > > b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > > new file mode 100644
> >
> > Perhaps add an entry in the MAINTAINERS file for this
> > .dts file similar to other freescale boards?
> The MAINTAINERS files has this entry
> M: Shawn Guo <shawnguo@xxxxxxxxxx>
> M: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> R: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> R: Fabio Estevam <festevam@xxxxxxxxx>
> R: NXP Linux Team <linux-imx@xxxxxxx>
> L: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> S: Maintained
> T: git git://
> N: imx
> N: mxs
> X: drivers/media/i2c/
> Shouldn't the "N: imx" cover this board already ?

Yes, it would, but not 'exclusively' by the

> Maybe I misunderstood, are you suggesting I add an new entry for "F:
> arch/arm64/boot/dts/freescale/*" ?

I don't believe an F: arch/arm64/boot/dts/freescale/*
pattern would be appropriate as there is already another
section with this path as a pattern.

M: Shawn Guo <shawnguo@xxxxxxxxxx>
M: Li Yang <>
L: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
S: Maintained
T: git git://
F: arch/arm/boot/dts/ls1021a*
F: arch/arm64/boot/dts/freescale/fsl-*
F: arch/arm64/boot/dts/freescale/qoriq-*

I suggest perhaps just adding a more specific entry of

F: arch/arm64/boot/dts/freescale/imx*

And just FYI:

F: entries should be preferred over N: entries as
filename collisions with other regex matches are common.

Controlling the mismatches as was done with the X: exclusion
for drivers/media/i2c/ may not scale if another filename
is added into the kernel tree that is not maintained by you
that matches either of the imx or mxs pattern.

It's not really a significant issue though you may get a few
patches for files you don't care about at some point.

cheers, Joe