Re: [PATCH] bonding: fix arp_validate toggling in active-backup mode
From: David Miller
Date: Mon May 13 2019 - 12:46:22 EST
From: Jarod Wilson <jarod@xxxxxxxxxx>
Date: Fri, 10 May 2019 17:57:09 -0400
> There's currently a problem with toggling arp_validate on and off with an
> active-backup bond. At the moment, you can start up a bond, like so:
> The problem lies in bond_options.c, where passing in arp_validate=0
> results in bond->recv_probe getting set to NULL. This flies directly in
> the face of commit 3fe68df97c7f, which says we need to set recv_probe =
> bond_arp_recv, even if we're not using arp_validate. Said commit fixed
> this in bond_option_arp_interval_set, but missed that we can get to that
> same state in bond_option_arp_validate_set as well.
> One solution would be to universally set recv_probe = bond_arp_recv here
> as well, but I don't think bond_option_arp_validate_set has any business
> touching recv_probe at all, and that should be left to the arp_interval
> code, so we can just make things much tidier here.
> Fixes: 3fe68df97c7f ("bonding: always set recv_probe to bond_arp_rcv in arp monitor")
> Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx>
Applied and queued up for -stable, thanks.