Re: [PATCH] drm/bridge: Remove duplicate header

From: Laurent Pinchart
Date: Tue May 14 2019 - 03:37:38 EST


Hi Sabyasachi,

Thank you for the patch.

On Tue, May 14, 2019 at 01:01:41PM +0530, Sabyasachi Gupta wrote:
> Remove drm/drm_panel.h which is included more than once
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@xxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/panel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba2..402b318 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_encoder.h>
> #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>

Which tree is this against ? The patch applies on neither drm-next nor
drm-misc-next.

While at it, could you you reorder the other header alphabetically to
make this kind of issue easier to notice ?

>
> struct panel_bridge {
> struct drm_bridge bridge;

--
Regards,

Laurent Pinchart