Re: [PATCH V2 1/3] perf parse-regs: Split parse_regs

From: Liang, Kan
Date: Wed May 15 2019 - 10:17:34 EST

On 5/15/2019 2:49 AM, Ravi Bangoria wrote:

On 5/15/19 1:49 AM, kan.liang@xxxxxxxxxxxxxxx wrote:
From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

The available registers for --int-regs and --user-regs may be different,
e.g. XMM registers.

Split parse_regs into two dedicated functions for --int-regs and
--user-regs respectively.

Modify the warning message. "--user-regs=?" should be applied to show
the available registers for --user-regs.

Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

For patch 1 and 2,
Tested-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxx>

Minor neat. Should we update document as well? May be something like:


Similar to -I, but capture user registers at sample time. To list the available
user registers use --user-regs=\?.

Hi Ravi,

Thanks for test.

The change of document looks good.