RE: [Intel-wired-lan] [PATCH][next] i40e: mark expected switch fall-through

From: Bowers, AndrewX
Date: Fri May 17 2019 - 18:39:01 EST


> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@xxxxxxxxxx] On
> Behalf Of Gustavo A. R. Silva
> Sent: Wednesday, May 1, 2019 1:56 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; intel-wired-lan@xxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Kees Cook <keescook@xxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH][next] i40e: mark expected switch fall-
> through
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
> we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/ethernet/intel/i40e/i40e_xsk.c: In function âi40e_run_xdp_zcâ:
> drivers/net/ethernet/intel/i40e/i40e_xsk.c:217:3: warning: this statement
> may fall through [-Wimplicit-fallthrough=]
> bpf_warn_invalid_xdp_action(act);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/intel/i40e/i40e_xsk.c:218:2: note: here
> case XDP_ABORTED:
> ^~~~
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
> we are expecting to fall through.
>
> This patch fixes the following warning:
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/i40e/i40e_xsk.c | 1 +
> 1 file changed, 1 insertion(+)

Tested-by: Andrew Bowers <andrewx.bowers@xxxxxxxxx>