Re: [PATCH V2 0/4] Prevent vhost kthread from hogging CPU

From: Michael S. Tsirkin
Date: Mon May 20 2019 - 08:55:28 EST


On Fri, May 17, 2019 at 12:29:48AM -0400, Jason Wang wrote:
> Hi:
>
> This series try to prevent a guest triggerable CPU hogging through
> vhost kthread. This is done by introducing and checking the weight
> after each requrest. The patch has been tested with reproducer of
> vsock and virtio-net. Only compile test is done for vhost-scsi.
>
> Please review.
> This addresses CVE-2019-3900.

OK I think we should clean this code some more but given
it's a CVE fix maybe it's best to do as a patch on top.

Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Dave do you want to merge this or should I?

>
> Changs from V1:
> - fix user-ater-free in vosck patch
>
> Jason Wang (4):
> vhost: introduce vhost_exceeds_weight()
> vhost_net: fix possible infinite loop
> vhost: vsock: add weight support
> vhost: scsi: add weight support
>
> drivers/vhost/net.c | 41 ++++++++++++++---------------------------
> drivers/vhost/scsi.c | 21 ++++++++++++++-------
> drivers/vhost/vhost.c | 20 +++++++++++++++++++-
> drivers/vhost/vhost.h | 5 ++++-
> drivers/vhost/vsock.c | 28 +++++++++++++++++++++-------
> 5 files changed, 72 insertions(+), 43 deletions(-)
>
> --
> 1.8.3.1