Re: [PATCH 1/3] firmware: qcom_scm: Use proper types for dma mappings

From: Julien Grall
Date: Mon May 20 2019 - 09:22:33 EST

Hi Ian,

On 20/05/2019 10:41, Ian Jackson wrote:
Stephen Boyd writes ("[PATCH 1/3] firmware: qcom_scm: Use proper types for dma mappings"):
We need to use the proper types and convert between physical addresses
and dma addresses here to avoid mismatch warnings. This is especially
important on systems with a different size for dma addresses and
physical addresses. Otherwise, we get the following warning:

Thanks. Do you expect this to be a backport candidate and if so how
far back do you think it will go ? To be honest, I am not really
convinced that backporting this would be a service to users. The
situation I have, where I changed the compiler but kept the old kernel
code and old configuration, is going to be fairly rare.

I will leave the maintainers answering to that.

I think I should probably therefore disable this driver in the config
on stable branches of Linux, at least.

If we decide to disable the driver, then we would need to add in our .config, then we would need to disable completely the support for Qualcomm (i.e CONFIG_ARCH_QCOM=n) on Arm32.

This should not be an issue in osstest as we don't test any qualcomm board so far.


Julien Grall