Re: [PATCH v2 1/2] pid: add pidfd_open()
From: Arnd Bergmann
Date: Mon May 20 2019 - 11:01:58 EST
On Mon, May 20, 2019 at 4:48 PM Christian Brauner <christian@xxxxxxxxxx> wrote:
> On Mon, May 20, 2019 at 04:37:03PM +0200, Arnd Bergmann wrote:
> > On Mon, May 20, 2019 at 3:46 PM Christian Brauner <christian@xxxxxxxxxx> wrote:
> > >
> > > In line with Arnd's recent changes to consolidate syscall numbers across
> > > architectures, I have added the pidfd_open() syscall to all architectures
> > > at the same time.
> > Thanks! I've checked that the ones you have added are all
> > done correctly. However, double-checking that you got all of them,
> > I noticed that you missed mips-o32 and mips-n64. With those added:
> > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> Perfect, will plumb mips-o32 and mips-n64 and resend once more with your
> ack added.
> Sidenote: You plan on merging the common syscall tables or will there be
> a script to do this work per-arch in the future?
David Howells also asked about this. I think having a common table will
be best in the long run, patches welcome.
As you noticed, there are still a few minor differences between the files
on mips, arm, x86, alpha and s390, and we are missing the .tbl files
for arm-compat and asm-generic, as well as an architecture independent
Once that is all taken care of, we can move the entries for syscall
403 and higher into a common file, and change the script to pick
up the contents from there in addition to the architecture specific