Re: [PATCH] platform/chrome: wilco_ec: Add version sysfs entries

[Nick Crews]

On Tue, May 21, 2019 at 9:15 AM Raul E Rangel <rrangel@xxxxxxxxxxxx> wrote:
>
> Add the ability to extract version information from the EC.
>
> Signed-off-by: Raul E Rangel <rrangel@xxxxxxxxxxxx>

Looks good to me, thanks Raul!
I applied to the chromium branch, and it works.

Reviewed-by: Nick Crews <ncrews@xxxxxxxxxxxx>
Tested-by: Nick Crews <ncrews@xxxxxxxxxxxx>

> ---
>
> This patch is rebased on platform/chrome: wilco_ec: Add Boot on AC support.
> https://lkml.org/lkml/2019/4/16/1374
>
> That patch wasn't in the for-next branch, so I'm not 100% sure if it
> applies cleanly to for-next.

It doesn't apply cleanly :(
You can add https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git
as the platform/chrome remote to ensure that it will apply cleanly.
It would probably be good for you to re-send this after rebasing it on for-next.