Re: [RFT PATCH v5 3/5] cpu-topology: Move cpu topology code to common code.
From: Will Deacon
Date: Fri May 24 2019 - 05:41:51 EST
On Fri, May 24, 2019 at 09:57:40AM +0100, Sudeep Holla wrote:
> On Fri, May 24, 2019 at 10:13:33AM +0200, Greg Kroah-Hartman wrote:
> > On Thu, May 23, 2019 at 05:06:50PM -0700, Atish Patra wrote:
> > > Both RISC-V & ARM64 are using cpu-map device tree to describe
> > > their cpu topology. It's better to move the relevant code to
> > > a common place instead of duplicate code.
> > >
> > > Signed-off-by: Atish Patra <atish.patra@xxxxxxx>
> > > Tested-by: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>
> > > ---
> > > arch/arm64/include/asm/topology.h | 23 ---
> > > arch/arm64/kernel/topology.c | 303 +-----------------------------
> > > drivers/base/arch_topology.c | 296 +++++++++++++++++++++++++++++
> > > include/linux/arch_topology.h | 28 +++
> > > include/linux/topology.h | 1 +
> > > 5 files changed, 329 insertions(+), 322 deletions(-)
> > What, now _I_ have to maintain drivers/base/arch_topology.c? That's
> > nice for everyone else, but not me :(
> > Ugh.
> > Anyway, what are you wanting to happen to this series? I think we need
> > some ARM people to sign off on it before I can take the whole thing,
> > right?
> Greg, I am ready to take ownership. Juri the original author of this file
> agreed and I have been reviewing this file since Juri first wrote it.
> I am happy to submit a patch assuming maintainership for this file, was
> just waiting to hear from you when I asked explicitly you and Juri in
> last version of the patch when Will wanted someone from ARM to be reviewer
> of this file at-least. I am happy to take over as reviewer or maintainer
> which ever you prefer.
Yes, please just include this update to MAINTAINERS as part of the series.
I'll ack it.