Re: [PATCH V2 4/9] genirq/timings: Use the min kernel macro
From: Daniel Lezcano
Date: Fri May 24 2019 - 12:14:15 EST
On 24/05/2019 15:57, Andy Shevchenko wrote:
> On Fri, May 24, 2019 at 01:16:10PM +0200, Daniel Lezcano wrote:
>> The' min' is available as a kernel macro. Use it instead of writing
>> the same code.
> While it's technically correct...
>> * 'count' will depends if the circular buffer wrapped or not
>> - count = irqs->count < IRQ_TIMINGS_SIZE ?
>> - irqs->count : IRQ_TIMINGS_SIZE;
>> + count = min_t(int, irqs->count, IRQ_TIMINGS_SIZE);
>> start = irqs->count < IRQ_TIMINGS_SIZE ?
>> 0 : (irqs->count & IRQ_TIMINGS_MASK);
> ...looking to the context I would leave as is to have a pattern.
Yes, you are right. I'll drop this patch.
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |