Re: [PATCH v4 02/13] platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on load

From: Daniel Drake
Date: Fri May 24 2019 - 16:01:05 EST

On Tue, May 14, 2019 at 12:51 PM Yurii Pavlovskyi
<yurii.pavlovskyi@xxxxxxxxx> wrote:
> The error code and return value are mixed up. The intensity is always set
> to 0 on load as kbd_led_read returns either 0 or negative value. To
> reproduce set backlight to maximum, reload driver and try to increase it
> using keyboard hotkey, the intensity will drop as a result. Correct the
> implementation.
> Signed-off-by: Yurii Pavlovskyi <yurii.pavlovskyi@xxxxxxxxx>

Reviewed-by: Daniel Drake <drake@xxxxxxxxxxxx>