Re: [PATCH][next] ASoC: cx2072x: fix integer overflow on unsigned int multiply

From: Takashi Iwai
Date: Sat May 25 2019 - 02:28:20 EST


On Sat, 25 May 2019 00:25:51 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the case where frac_div larger than 96 the result of an unsigned
> multiplication overflows an unsigned int. For example, this can
> happen when the sample_rate is 192000 and pll_input is 122. Fix
> this by casing the first term of the mutiply to a u64. Also remove
> the extraneous parentheses around the expression.
>
> Addresses-Coverity: ("Unintentional integer overflow")
> Fixes: a497a4363706 ("ASoC: Add support for Conexant CX2072X CODEC")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi