Re: [PATCH v4] locking/lock_events: Use this_cpu_add() when necessary

From: Linus Torvalds
Date: Mon May 27 2019 - 15:37:34 EST


On Mon, May 27, 2019 at 1:23 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> That's disguisting... I see Linus already applied it, but yuck. That's
> what we have raw_cpu_*() for.

Ahh, I tried to look for that, but there was enough indirection and
confusion that I wasn't sure they were generically available.

And the "raw_cpu_*()" functions are rare enough that I'd never
encountered them enough to really be aware of them. In fact, we seem
to have exactly _one_ user of "raw_cpu_add()" in the whole kernel, and
a handful of "raw_cpu_inc()".

But ack on your patch, and a heartfelt "yeah, that's the right thing". Thanks,

Linus