Re: [PATCH v6 4/4] x86/acrn: Add hypercall for ACRN guest
From: Borislav Petkov
Date: Mon May 27 2019 - 18:49:41 EST
On Mon, May 27, 2019 at 10:57:09AM +0800, Zhao, Yakui wrote:
> I refer to the Xen/KVM hypercall to add the ACRN hypercall in one separate
> The ACRN hypercall is defined in one separate acrn_hypercall.h and can be
> included explicitly by the *.c that needs the hypercall.
Sure but what else will need the hypercall definition except stuff which
already needs acrn.h? I.e., why is the separate header needed?
> The hypercall will be used in driver part. Before the driver part is added,
> it seems that the defined ACRN hypercall functions are not used.
> Do I need to add these functions together with driver part?
Yes, send functions together with the stuff which uses them pls.
ECO tip #101: Trim your mails when you reply. Srsly.