Re: [PATCH v3 1/9] leds: multicolor: Add sysfs interface definition

[Dan Murphy]

Pavel

On 5/27/19 5:33 AM, Pavel Machek wrote:
> On Thu 2019-05-23 14:08:12, Dan Murphy wrote:
> > Add a documentation of LED Multicolor LED class specific
> > sysfs attributes.
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> >   .../ABI/testing/sysfs-class-led-multicolor    | 57 +++++++++++++++++++
> >   1 file changed, 57 insertions(+)
> >   create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor
> >
> > diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor b/Documentation/ABI/testing/sysfs-class-led-multicolor
> > new file mode 100644
> > index 000000000000..2f102ede258b
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor
> > @@ -0,0 +1,57 @@
> > +What:		/sys/class/leds/<led>/colors/sync_enable
> > +Date:		April 2019
> I believe I suggested more reasonable interface. Why not use that?

Can you please provide the reference to your interface?

These patchsets have been around for a while (Decemeber 2018) and I 
cannot seem to find the reference to your suggestion.

The suggestion may have been mired in the brightness model discussions.

So I don't want to over look what you suggested as it may be more 
reasonable then what I have implemented.

Dan