Re: [PATCH V2 1/3] perf/x86: Disable non generic regs for software/probe events

From: Peter Zijlstra
Date: Tue May 28 2019 - 10:08:47 EST


On Tue, May 28, 2019 at 09:33:40AM -0400, Liang, Kan wrote:
> Uncore PMU doesn't support sampling. It will return -EINVAL.
> There is no regs support for counting. The request will be ignored.
>
> I think current check for uncore is good enough.

breakpoints then.. There's also no guarantee you covered all software
events, and the core rewrite will allow other per-task/sampling PMUs
too.

The approach you take is just not complete, don't do that.