Re: [PATCHv4 2/4] firmware: add Intel Stratix10 remote system update driver
From: Greg KH
Date: Tue May 28 2019 - 19:27:26 EST
On Tue, May 28, 2019 at 03:20:31PM -0500, richard.gong@xxxxxxxxxxxxxxx wrote:
> +static int rsu_send_msg(struct stratix10_rsu_priv *priv,
> + enum stratix10_svc_command_code command,
> + unsigned long arg,
> + void (*callback)(struct stratix10_svc_client *client,
> + struct stratix10_svc_cb_data *data))
Odd indentation for arg, and then callback.
Why isn't callback a typedef to make this simpler to use?