Re: [PATCH v4 00/16] Software fwnode references

From: Hans de Goede
Date: Wed May 29 2019 - 05:32:40 EST


On 5/22/19 12:50 PM, Heikki Krogerus wrote:

I'm not splitting this series in two after all. After thinking about
this for some time, I decided to add support for static software
nodes. I did not want to support them because I don't want to make it
easy to maintain board files, but in end they make the use of the
software nodes so much more easier compared to if we always had to
dynamically allocate them that it's a no-brainer. The references can
now be also described statically. Actually, those can now only be
described statically.

Hans! I applied (hopefully) all of the fixes you proposed in v3. I
hope you have time to test these.

I've just ran various tests with the entire series applied and
everything (superspeed host, superspeed device, DP over Type-C,
PD charging) seems to work fin, so you can add my:

Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>

To the entire series.

I've 2 very minor nitpicks about the intel_cht_int33fe patches,
with those fixed, you can also add my:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

To the intel_cht_int33fe patches. I will reply to the
2 individual patches for which I've some remarks