Re: [PATCH net v2] net: dsa: mv88e6xxx: fix handling of upper half of STATS_TYPE_PORT

From: Vivien Didelot
Date: Wed May 29 2019 - 13:19:57 EST


Hi Rasmus,

On Wed, 29 May 2019 07:02:11 +0000, Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx> wrote:
> Currently, the upper half of a 4-byte STATS_TYPE_PORT statistic ends
> up in bits 47:32 of the return value, instead of bits 31:16 as they
> should.
>
> Fixes: 6e46e2d821bb ("net: dsa: mv88e6xxx: Fix u64 statistics")
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx>

Correct, this 4-byte stat must be stored in the lower half of the
8-byte returned value:

Reviewed-by: Vivien Didelot <vivien.didelot@xxxxxxxxx>