Re: [PATCH net-next 0/5] PTP support for the SJA1105 DSA driver

From: Richard Cochran
Date: Wed May 29 2019 - 23:49:44 EST


On Wed, May 29, 2019 at 11:41:22PM +0300, Vladimir Oltean wrote:
> I'm sorry, then what does this code from raw.c do?

It is a fallback for HW that doesn't support multicast filtering.

Care to look a few lines above? If you did, you would have seen this:

memset(&mreq, 0, sizeof(mreq));
mreq.mr_ifindex = index;
mreq.mr_type = PACKET_MR_MULTICAST;
mreq.mr_alen = MAC_LEN;
memcpy(mreq.mr_address, addr1, MAC_LEN);

err1 = setsockopt(fd, SOL_PACKET, option, &mreq, sizeof(mreq));

> > No. The root cause is the time stamps delivered by the hardware or
> > your driver. That needs to be addressed before going forward.
> >
>
> How can I check that the timestamps are valid?

Well, you can see that there is something wrong. Perhaps you are not
matching the meta frames to the received packets. That is one
possible explanation, but you'll have to figure out what is happening.

Thanks,
Richard