Re: [PATCH 2/2] edac: add support for Amazon's Annapurna Labs EDAC

From: Greg KH
Date: Thu May 30 2019 - 08:01:09 EST


On Thu, May 30, 2019 at 01:15:29PM +0300, Hanna Hawa wrote:
> +static void al_a57_edac_cpumerrsr(void *arg)
> +{
> + struct edac_device_ctl_info *edac_dev =
> + (struct edac_device_ctl_info *)arg;

No need for casting anything here, just assign it. Doesn't checkpatch
catch this type of thing these days? You did run it, right?

Please fix that up everywhere you do this in the driver.


thanks,

greg k-h