Re: [PATCH uprobe, thp 4/4] uprobe: collapse THP pmd after removing all uprobes

From: Kirill A. Shutemov
Date: Thu May 30 2019 - 08:24:37 EST


On Wed, May 29, 2019 at 02:20:49PM -0700, Song Liu wrote:
> After all uprobes are removed from the huge page (with PTE pgtable), it
> is possible to collapse the pmd and benefit from THP again. This patch
> does the collapse.

I don't think it's right way to go. We should deferred it to khugepaged.
We need to teach khugepaged to deal with PTE-mapped compound page.
And uprobe should only kick khugepaged for a VMA. Maybe synchronously.

--
Kirill A. Shutemov