Re: [PATCH 4.19 051/276] selftests/bpf: set RLIMIT_MEMLOCK properly for test_libbpf_open.c

[Pavel Machek]

> Signed-off-by: Yonghong Song <yhs@xxxxxx>
> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>  tools/testing/selftests/bpf/test_libbpf_open.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/test_libbpf_open.c b/tools/testing/selftests/bpf/test_libbpf_open.c
> index 8fcd1c076add0..cbd55f5f8d598 100644
> --- a/tools/testing/selftests/bpf/test_libbpf_open.c
> +++ b/tools/testing/selftests/bpf/test_libbpf_open.c
> @@ -11,6 +11,8 @@ static const char *__doc__ =
>  #include <bpf/libbpf.h>
>  #include <getopt.h>
>  
> +#include "bpf_rlimit.h"
> +
>  static const struct option long_options[] = {
>  	{"help",	no_argument,		NULL, 'h' },
>  	{"debug",	no_argument,		NULL, 'D' },

header file with side effects... That's no header file, that's a .c
file. Perhaps we should name it as such?

I thought "this can't be right" when I first saw it..
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature