Re: linux-next: Tree for May 30 (firmware_loader)

[Matteo Croce]

On May 31, 2019 2:06:46 AM GMT+02:00, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> Hi all,
> 
> On Thu, 30 May 2019 09:10:13 -0700 Randy Dunlap
> <rdunlap@xxxxxxxxxxxxx> wrote:
> >
> > on i386 or x86_64:
> > when CONFIG_PROC_SYSCTL is not set/enabled:
> > 
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x1c):
> undefined reference to `sysctl_vals'
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x20):
> undefined reference to `sysctl_vals'
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x40):
> undefined reference to `sysctl_vals'
> > ld: drivers/base/firmware_loader/fallback_table.o:(.data+0x44):
> undefined reference to `sysctl_vals'
> 
> Caused by commit
> 
>   6a33853c5773 ("proc/sysctl: add shared variables for range check")
> 
> Added some more cc's

Hi,

Probably the whole firmware_config_table declaration should be under #ifdef CONFIG_PROC_SYSCTL?

I'll look into it, thanks.
-- 
Matteo Croce
per aspera ad upstream