Re: [PATCH V2] drivers: i2c: tegra: fix checkpatch defects

[Bitan Biswas]

On 5/30/19 4:43 AM, Dmitry Osipenko wrote:
> 30.05.2019 14:36, Dmitry Osipenko ÐÐÑÐÑ:
> > 30.05.2019 9:14, Bitan Biswas ÐÐÑÐÑ:
> > > Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c
> > > except for BUG/BUG_ON checks
> >
> > Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire,
> > hence there is absolutely no good reason in making system unusable on a
> > software bug. BUG_ON may be more useful for development, but not for a
> > casual daily usage.
I shall update the patch to remove the BUG/BUG_ON calls.

> > > Signed-off-by: Bitan Biswas <bbiswas@xxxxxxxxxx>
> > > ---
> >
> > > @@ -1034,7 +1038,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
> > >   	u32 *buffer = NULL;
> > >   	int err = 0;
> > >   	bool dma;
> > > -	u16 xfer_time = 100;
> > > +	u16 xfer_tm = 100;
> >
> > What's wrong with the "time"? I'm finding the "xfer_tm" as a very
> > unintuitive naming.
>
> Also, please don't version patch as v2 if v1 was never sent out.
I marked the patch version as V2 incorrectly. Sorry. I shall be careful 
about the patch version sequence from now on.

-regards,
 Bitan