Re: [PATCH net-next 0/5] PTP support for the SJA1105 DSA driver

From: Richard Cochran
Date: Sat Jun 01 2019 - 01:07:06 EST

On Fri, May 31, 2019 at 07:16:17PM +0300, Vladimir Oltean wrote:
> But now comes the question on what to do on error cases - the meta
> frame didn't arrive. Should I just drop the skb waiting for it?

Yes, that is what other drivers do.

> Right now I "goto rcv_anyway" - which linuxptp doesn't like btw.

The application sees the missing time stamp and prints a warning
message. This is IHMO the right thing to do, so that the user is made
aware of the degradation of the synchronization.