RE: [PATCH v3 1/2] dt-bindings: clock: renesas,r9a06g032-sysctrl: Document power Domains
From: Phil Edworthy
Date: Mon Jun 03 2019 - 04:54:34 EST
On 03 June 2019 09:39 Geert Uytterhoeven wrote:
> On Mon, Jun 3, 2019 at 10:29 AM Phil Edworthy wrote:
> > On 28 May 2019 08:29 Geert Uytterhoeven wrote:
> > > On Fri, May 24, 2019 at 5:32 PM Gareth Williams wrote:
> > > > The driver is gaining power domain support, so add the new property to
> > > > the DT binding and update the examples.
> > > >
> > > > Signed-off-by: Gareth Williams <gareth.williams.jx@xxxxxxxxxxx>
> > > > ---
> > > > a/Documentation/devicetree/bindings/clock/renesas,r9a06g032-
> > > > +++ b/Documentation/devicetree/bindings/clock/renesas,r9a06g032-
> > > @@ -40,4 +42,5 @@ Examples
> > > > reg-io-width = <4>;
> > > > clocks = <&sysctrl R9A06G032_CLK_UART0>;
> > > > clock-names = "baudclk";
> > > > + power-domains = <&sysctrl>;
> > >
> > > This is an interesting example: according to the driver,
> > > R9A06G032_CLK_UART0, is not clock used for power management?
> > >
> > > Oh, the real uart0 node in arch/arm/boot/dts/r9a06g032.dtsi uses
> > >
> > > clocks = <&sysctrl R9A06G032_CLK_UART0>, <&sysctrl
> > > R9A06G032_HCLK_UART0>;
> > > clock-names = "baudclk", "apb_pclk";
> > >
> > > That does make sense...
> > Note that the Synopsys DW uart driver already gets the "apb_pclk" clock,
> > we donât actually need to use clock domains to enable this clock.
> That is not necessarily a problem:
> 1) DT describes hardware, not software policy,
> 2) It doesn't hurt to enable a clock twice.
Yes, that was my take as well.
> There are still some R-Car drivers that manage clocks themselves, but
> we're slowly migrating away from that, where possible. If the driver
> is e.g. shared with a platform without clock domains, we obviously cannot
> do that.
> So you can take out that code again, that's up to you.
I think leaving it as is best.
> > This is also true for many of the peripheral drivers used on rzn1 (Synopsys
> > gpio controller, i2c controller, gmac, dmac, Arasan sdio controller). The
> > commit to add this clock to the i2c controller driver is my fault, as I was
> > following the pattern of the others.
> > Of the few drivers that don't already get the hclk/pclk used to access the
> > peripherals is the Synopsys spi controller (though that currently doesnât
> > support runtime PM) and the USB Host controller.
> Good, so the latter will start working magically, I assume? ;-)
Yes, except for the usb PLL. The rzn1 has a mode bit that switches USB
between 2xHost and 1xHost + 1xFunc, however the PLL must be started after
the mode bit has been set. That still needs to be implemented...
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds