Re: [PATCH v3 1/2] gpio: Add support for hierarchical IRQ domains
From: Linus Walleij
Date: Mon Jun 03 2019 - 07:02:03 EST
On Mon, Jun 3, 2019 at 9:53 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> > Please drop this. The default .to_irq() should be good for everyone.
> > Also patch 2/2 now contains a identical copy of the gpiolib
> > .to_irq() which I suspect you indended to drop, actually.
> It's not actually identical to the gpiolib implementation. There's still
> the conversion to the non-linear DT representation for GPIO specifiers
> from the linear GPIO number space, which is not taken care of by the
> gpiolib variant. That's precisely the point why this patch makes it
> possible to let the driver override things.
OK something is off here, because the purpose of the irqdomain
is exactly to translate between different number spaces, so it should
not happen in the .to_irq() function at all.
Irqdomain uses .map() in the old variant and .translate() in the
hierarchical variant to do this, so something is skewed.
All .to_irq() should ever do is just call the irqdomain to do the
translation, no other logic (unless I am mistaken) so we should
be able to keep the simple .to_irq() logic inside gpiolib.