Re: [PATCH 2/7] media: cedrus: Fix H264 default reference index count

From: Maxime Ripard
Date: Mon Jun 03 2019 - 07:50:16 EST

On Thu, May 30, 2019 at 11:15:11PM +0200, Jernej Skrabec wrote:
> Reference index count in VE_H264_PPS reg should come from PPS control.
> However, this is not really important because reference index count is
> in our case always overridden by that from slice header.
> Cc: nicolas@xxxxxxxxxxxx
> Cc: boris.brezillon@xxxxxxxxxxxxx
> Cc: jonas@xxxxxxxxx
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx>

Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxx>

> ---
> We have to decide if we drop pps->num_ref_idx_l0_default_active_minus1
> and pps->num_ref_idx_l1_default_active_minus1 fields or add
> num_ref_idx_l0_active_override_flag and num_ref_idx_l0_active_override_flag
> to slice control.
> Current control doesn't have those two flags, so in Cedrus override flag is
> always set and we rely on userspace to set slice->num_ref_idx_l0_active_minus1
> and slice->num_ref_idx_l1_active_minus1 to correct values. This means that
> values stored in PPS are not needed and always ignored by VPU.
> If I understand correctly, algorithm is very simple:
> ref_count = PPS->ref_count
> if (override_flag)
> ref_count = slice->ref_count
> It seems that VAAPI provides only final value. In my opinion we should do the
> same - get rid of PPS default ref index count fields.

The rationale was to be as conservative as possible and just expose
everything that is in the bitstream in those controls to accomodate
for as many weird hardware as possible.


Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering

Attachment: signature.asc
Description: PGP signature