Re: [PATCHv2 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast()

From: Christoph Hellwig
Date: Mon Jun 03 2019 - 12:46:00 EST

> +#if defined(CONFIG_CMA)

You can just use #ifdef here.

> +static inline int reject_cma_pages(int nr_pinned, unsigned int gup_flags,
> + struct page **pages)

Please use two instead of one tab to indent the continuing line of
a function declaration.

> +{
> + if (unlikely(gup_flags & FOLL_LONGTERM)) {

IMHO it would be a little nicer if we could move this into the caller.