Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optional

From: Daniel Lezcano
Date: Tue Jun 04 2019 - 02:08:15 EST


On 04/06/2019 07:56, Andy Tang wrote:
> Hi Edubezval, Rui,
>
> Any further comments?

>From my POV, this patch makes sense. We may be interested to show up the
thermal zones in sysfs and optionally mitigate them via an userspace
governor.

Acked-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

>> -----Original Message-----
>> From: Yuantian Tang <andy.tang@xxxxxxx>
>> Sent: 2019年5月15日 17:37
>> To: rui.zhang@xxxxxxxxx; edubezval@xxxxxxxxx
>> Cc: robh+dt@xxxxxxxxxx; daniel.lezcano@xxxxxxxxxx; mark.rutland@xxxxxxx;
>> linux-pm@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
>> linux-kernel@xxxxxxxxxxxxxxx; Andy Tang <andy.tang@xxxxxxx>
>> Subject: [PATCH] dt-bindings: thermal: Make cooling-maps property optional
>>
>> There may be no cooling device on system, or there are no enough cooling
>> devices for each thermal zone in multiple thermal zone cases since cooling
>> devices can't be shared.
>> So make this property optional to remove such limitations.
>>
>> Signed-off-by: Yuantian Tang <andy.tang@xxxxxxx>
>> ---
>> .../devicetree/bindings/thermal/thermal.txt | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt
>> b/Documentation/devicetree/bindings/thermal/thermal.txt
>> index ca14ba9..694e834 100644
>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>> @@ -142,11 +142,11 @@ Required properties:
>> - trips: A sub-node which is a container of only trip point nodes
>> Type: sub-node required to describe the thermal zone.
>>
>> +
>> +Optional property:
>> - cooling-maps: A sub-node which is a container of only cooling device
>> Type: sub-node map nodes, used to describe the relation between
>> trips
>> and cooling devices.
>> -
>> -Optional property:
>> - coefficients: An array of integers (one signed cell) containing
>> Type: array coefficients to compose a linear relation between
>> Elem size: one cell the sensors listed in the thermal-sensors property.
>> --
>> 1.7.1
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog