Re: [PATCH v4 4/9] ASoC: sun4i-i2s: Reduce quirks for sun8i-h3
From: Code Kipper
Date: Tue Jun 04 2019 - 05:37:19 EST
On Tue, 4 Jun 2019 at 09:46, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
> On Mon, Jun 03, 2019 at 07:47:30PM +0200, codekipper@xxxxxxxxx wrote:
> > From: Marcus Cooper <codekipper@xxxxxxxxx>
> > We have a number of flags used to identify the functionality
> > of the IP block found on the sun8i-h3 and later devices. As it
> > is only neccessary to identify this new block then replace
> > these flags with just one.
> > Signed-off-by: Marcus Cooper <codekipper@xxxxxxxxx>
> This carries exactly the same meaning than the compatible, so this is
> entirely redundant.
> The more I think of it, the more I fell like we should have function
> pointers instead, and have hooks to deal with these kind of things.
> I've been working a lot on that driver recently, and there's some many
> parameters and regmap_fields that it becomes pretty hard to work on.
let's sync with what you're doing as you're more lightly to see it
through to delivery!
I was trying to clean up the driver as some of this seemed a bit unnecessary,
hooks sounds like the way forward,
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering