Re: [PATCH 01/22] perf intel-pt: Fix itrace defaults for perf script
From: Adrian Hunter
Date: Tue Jun 04 2019 - 07:37:23 EST
On 31/05/19 7:45 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, May 20, 2019 at 11:45:16AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Mon, May 20, 2019 at 02:37:07PM +0300, Adrian Hunter escreveu:
>>> Commit 4eb068157121 ("perf script: Make itrace script default to all
>>> calls") does not work because 'use_browser' is being used to determine
>>> whether to default to periodic sampling (i.e. better for perf report).
>>> The result is that nothing but CBR events display for perf script
>>> when no --itrace option is specified.
>>> Fix by using 'default_no_sample' and 'inject' instead.
>> Applied 1-3 for now, concentrating on fixes, will process 4-22 later.
> Tested the ones that affect sqlite databases an the GUI, all look good,
> added committer notes and text screenshots as committer notes, thanks!
Thanks for applying! Are patches 11-22 in your tree?