Re: [PATCH] media: do not use C++ style comments in uapi headers

From: Arnd Bergmann
Date: Tue Jun 04 2019 - 07:58:33 EST


On Tue, Jun 4, 2019 at 1:23 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Tue, 2019-06-04 at 20:13 +0900, Masahiro Yamada wrote:
> > On the other hand, uapi headers are written in more strict C, where
> > the C++ comment style is forbidden.
>
> Is this a real problem for any toolchain?

There is likely some code that is built with -Wpedandic -Werror --std=c89
or similar. Since glibc allows this combination for its own headers, it seems
best to also allow it in kernel headers that may be included by libc headers
or by applications, at least where it does not hurt.

Realistically though, we probably assume c99 or gnu89 in user space
headers anyway, since there is no 'long long' in earlier standards.

Arnd