Re: [PATCH v3 net-next 04/17] net: dsa: sja1105: Move sja1105_change_tpid into sja1105_vlan_filtering
From: Florian Fainelli
Date: Tue Jun 04 2019 - 17:02:13 EST
On 6/4/2019 10:07 AM, Vladimir Oltean wrote:
> This is a cosmetic patch, pre-cursor to making another change to the
> General Parameters Table (incl_srcpt) which does not logically pertain
> to the sja1105_change_tpid function name, but not putting it there would
> otherwise create a need of resetting the switch twice.
> So simply move the existing code into the .port_vlan_filtering callback,
> where the incl_srcpt change will be added as well.
> Signed-off-by: Vladimir Oltean <olteanv@xxxxxxxxx>
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>