Re: [PATCH v2] Add a document on rebasing and merging
From: Theodore Ts'o
Date: Tue Jun 04 2019 - 21:59:11 EST
On Tue, Jun 04, 2019 at 01:48:35PM -0600, Jonathan Corbet wrote:
> +Maintaining a subsystem, as a general rule, requires a familiarity with
> the +Git source-code management system. Git is a powerful tool with a lot
> of +features; as is often the case with such tools, there are right and
> wrong +ways to use those features. This document looks in particular at
> the use +of rebasing and merging. Maintainers often get in trouble when
> they use +those tools incorrectly, but avoiding problems is not actually
> all that +hard.
FYI, it looks like your patch somehow got hit by your text editor (or
MUA's) line wrapping...
> + - Realize that the rebasing a patch series changes the environment in
> + which it was developed and, likely, invalidates much of the testing
> + was done. A rebased patch series should, as a general rule, be treated
> + like new code and retested from the beginning.
Shouldn't "reparenting" be used in this paragraph?
I suppose if a patch is getting dropped or modified that can
invalidate some of the testing (although it really depends on the
nature of what's being dropped or modified). And if it's just adding
a Tested-by tag or a CVE number in the commit description, it's not
going to invalidate any testing.
As an aside, I wonder if git could pass down some kind of hint at "git
fetch" time that a particular branch is one that is subject to
frequent history rewriting, so it shouldn't be used as the basis for
further work (unless the developer is someone who is really good at
the "git rebase --onto ..." syntax).
> +Even in the absence of known conflicts, doing a test merge before sending
> a +pull request is a good idea. It may alert you to problems that you
> somehow +didn't see from linux-next and helps to understand exactly what
> you are +asking upstream to do.
Some maintainers will actually do a test merge and then run regression
tests on the result --- more than just a "it builds, ship it!" :-)
> +Another reason for doing merges of upstream or another subsystem tree is
> to +resolve dependencies. These dependency issues do happen at times, and
> +sometimes a cross-merge with another tree is the best way to resolve them;
> +as always, in such situations, the merge commit should explain why the
> +merge has been done. Take a momehnt to do it right; people will read those
It might also be useful to mention it might be useful to put the
commits which are needed to solve the dependency problem on its own
separate branch, based off of something like -rc2, and then each of
the trees which need the prerequisite commits can merge in that
BTW, this is another example where, if we couldn't figure this out in
advance, I might consider it worthwhile to separate out prerequisite
patches, and reparent them on top of -rc2, so that other trees don't
have to do a cross-merge which pulls in half of some other subsystem's
branch. Rewriting history on one branch and reparenting the changes
so they are on their own branch might be a good tradeoff if it avoids
messy cross-merges on multiple other trees. It also avoids this
> .... If that subsystem tree fails to be pulled
> +upstream, whatever problems it had will block the merging of your tree as