Re: [PATCH v3 4/6] i2c: core: Move ACPI IRQ handling to probe time
From: Charles Keepax
Date: Wed Jun 05 2019 - 04:27:27 EST
On Tue, Jun 04, 2019 at 08:04:04PM +0300, Andy Shevchenko wrote:
> On Tue, May 28, 2019 at 03:28:58PM +0100, Charles Keepax wrote:
> > Bring the ACPI path in sync with the device tree path and handle all the
> > IRQ fetching at probe time. This leaves the only IRQ handling at device
> > registration time being that which is passed directly through the board
> > info as either a resource or an actual IRQ number.
> It seems my comments weren't addressed by one or another reason.
> This one I would rather to split with exporting function as a separate patch.
With the switch to passing in i2c_client it makes for some fairly
awkward gymnastics and "ping pong" programming to do so. I guess
we could leave the function taking in an acpi_device but just
felt like a slightly less user friendly interface. Any thoughts?