Re: [5.2 regression] copy_fpstate_to_sigframe() change causing crash in 32-bit process

From: Sebastian Andrzej Siewior
Date: Wed Jun 05 2019 - 10:08:27 EST


On 2019-06-04 11:53:58 [-0700], Eric Biggers wrote:
> On latest Linus' tree I'm getting a crash in a 32-bit Wine process.
>
> I bisected it to the following commit:
>
> commit 39388e80f9b0c3788bfb6efe3054bdce0c3ead45
> Author: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Date: Wed Apr 3 18:41:35 2019 +0200
>
> x86/fpu: Don't save fxregs for ia32 frames in copy_fpstate_to_sigframe()
>
> Reverting the commit by applying the following diff makes the problem go away.

This looked like a merge artifact and it has been confirmed as such. Now
you say that this was a needed piece of code. Interesting.
Is that wine process/testcase something you can share? I will try to
take a closer look.

Sebastian