RE: [PATCH 1/3] x86/CPU: Add more Icelake model number
From: Zhuo, Qiuxu
Date: Thu Jun 06 2019 - 03:17:27 EST
> From: Borislav Petkov [mailto:bp@xxxxxxxxx]
> > From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> > Add the CPUID model number of Icelake (ICL) desktop and server
> > processors to the Intel family list.
> > Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
> > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>
> You're sending this patch but it has Qiuxu's SOB too. What's that supposed to mean?
During internal co-work, based on Kan's original patch, I got the "#define" in the Ice Lake group sorted by model number(the header of the file requires the sorting) and added my SOB. Dropping my SOB or adding a text "[Qiuxu: Get the macros in the Ice Lake group sorted by model number.]" at the end of the commit message - which one is better/clear for you?