Re: [PATCH 3/3] livepatch: Use static buffer for debugging messages under rq lock
From: Petr Mladek
Date: Thu Jun 06 2019 - 09:31:52 EST
On Fri 2019-05-31 14:39:08, Josh Poimboeuf wrote:
> On Fri, May 31, 2019 at 09:41:47AM +0200, Petr Mladek wrote:
> > The err_buf array uses 128 bytes of stack space. Move it off the stack
> > by making it static. It's safe to use a shared buffer because
> > klp_try_switch_task() is called under klp_mutex.
> > Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>
> > Acked-by: Miroslav Benes <mbenes@xxxxxxx>
> > Reviewed-by: Kamalesh Babulal <kamalesh@xxxxxxxxxxxxxxxxxx>
> Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
The patch is committed into for-5.3/core branch.
Note that the branch is based on the last merge from livepatch.git.
As a result, the sefttest fails because of the regression in
the reliable stacktrace code.
You might want to base your development on the for-next branch.
Or you chould cherry pick the commit 7eaf51a2e094229b75cc0c31
("[PATCH] stacktrace: Unbreak stack_trace_save_tsk_reliable()").
PS: I am leaving the fate of the other two patches into Miroslav's