Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper

From: Roman Gushchin
Date: Thu Jun 06 2019 - 20:14:38 EST


On Fri, Jun 07, 2019 at 02:00:20AM +0200, Daniel Borkmann wrote:
> On 06/06/2019 10:30 PM, Roman Gushchin wrote:
> > Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
> > programs. An attempt to load such a program generates an error
> > like this:
> >
> > libbpf:
> > 0: (b7) r6 = 0
> > ...
> > 9: (85) call bpf_skb_cgroup_id#79
> > unknown func bpf_skb_cgroup_id#79
> >
> > There are no particular reasons for denying it, and we have some
> > use cases where it might be useful.
> >
> > So let's add it to the list of allowed helpers.
> >
> > Signed-off-by: Roman Gushchin <guro@xxxxxx>
> > Cc: Yonghong Song <yhs@xxxxxx>
> > Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
> > Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>
>
> Applied, thanks!

Thank you, Daniel!