Re: [PATCH 2/3] au1200fb: fix DMA API abuse
From: Bartlomiej Zolnierkiewicz
Date: Fri Jun 07 2019 - 08:18:56 EST
On 5/15/19 1:10 PM, Manuel Lauss wrote:
> Servus Christoph,
> On Thu, May 9, 2019 at 7:39 PM Christoph Hellwig <hch@xxxxxx> wrote:
>> Virtual addresses return from dma(m)_alloc_attrs are opaque in what
>> backs then, and drivers must not poke into them. Similarly caching
>> modes are not supposed to be directly set by the driver. Switch the
>> driver to use the generic DMA API mmap helper to avoid these problems.
>> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>> drivers/video/fbdev/au1200fb.c | 19 ++++---------------
>> 1 file changed, 4 insertions(+), 15 deletions(-)
> Runs fine on my test system.
> Tested-by: Manuel Lauss <manuel.lauss@xxxxxxxxx>
Patch queued for v5.3, thanks.
Samsung R&D Institute Poland