Re: [PATCH v5] i2c: i801: Register optional lis3lv02d I2C device on Dell machines

From: Jean Delvare
Date: Fri Jun 07 2019 - 10:20:59 EST

On Thu, 6 Jun 2019 20:18:45 +0200, Pali RohÃr wrote:
> Dell platform team told us that some (DMI whitelisted) Dell Latitude
> machines have ST microelectronics accelerometer at I2C address 0x29.
> Presence of that ST microelectronics accelerometer is verified by existence
> of SMO88xx ACPI device which represent that accelerometer. Unfortunately
> ACPI device does not specify I2C address.
> This patch registers lis3lv02d device for selected Dell Latitude machines
> at I2C address 0x29 after detection. And for Dell Vostro V131 machine at
> I2C address 0x1d which was manually detected.
> Finally commit a7ae81952cda ("i2c: i801: Allow ACPI SystemIO OpRegion to
> conflict with PCI BAR") allowed to use i2c-i801 driver on Dell machines so
> lis3lv02d correctly initialize accelerometer.
> Tested on Dell Latitude E6440.
> Signed-off-by: Pali RohÃr <pali.rohar@xxxxxxxxx>
> ---
> Changes since v4:
> * Remove usage of redundant acpi_bus_get_status_handle()
> * Update comment about acpi_get_devices()
> (...)

Looks all good now.

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Jean Delvare
SUSE L3 Support