Re: [PATCH 2/2] arm64: dts: rockchip: Define values for the IPA governor for rock960

From: Linus Walleij
Date: Fri Jun 07 2019 - 18:22:48 EST

On Tue, Jun 4, 2019 at 6:58 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:

> The intelligent power allocator PID coefficient to be set in sysfs
> are:
> k_d: 0
> k_po: 79
> k_i: 10
> k_pu: 50

With all the other interesting parametrization in the device tree
I kind of wonder why the PID regulator constants defaults are
not set up from device tree?

Any specific reason?

To me it seems like the kind of stuff userpace will invariably just
get wrong or forget about (somebody just runs a different
distribution without the extra magic to set sysfs right) unless
we supply good defaults.

Linus Walleij